Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cards should have the same size #1399

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix: cards should have the same size #1399

merged 2 commits into from
Oct 7, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Oct 7, 2024

Fix #1342

Before After
image image

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

/backport to stable30

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

/backport to stable29

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

/backport to stable28

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

/compile

Signed-off-by: nextcloud-command <[email protected]>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@susnux
Copy link
Contributor

susnux commented Oct 7, 2024

backport to stable28

Was it already added there? I thought we touched it only for 29+?

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

backport to stable28

Was it already added there? I thought we touched it only for 29+?

Ah right. I don't remember 🙈

@szaimen szaimen merged commit 8be1c28 into master Oct 7, 2024
40 checks passed
@szaimen szaimen deleted the fix/1342/fix-cards branch October 7, 2024 15:05
@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

I guess wel' see son ;)

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

Is the backport bot down?

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

/backport to stable30

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

/backport to stable29

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

/backport to stable28

Copy link

backportbot bot commented Oct 7, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/1399/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d94ae3a9 be08a6a3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1399/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@szaimen
Copy link
Collaborator Author

szaimen commented Oct 7, 2024

Okay, 28 doesnt have it apparently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: the height is not the same
3 participants